Do not add signature to memory for private function calls#2058
Merged
iamdefinitelyahuman merged 1 commit intoJun 27, 2020
Merged
Conversation
fubuloubu
approved these changes
Jun 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Do not write a signature to memory when preparing args for a private function call. Fixes #1695
How I did it
In
vyper/parser/parser_utils.py::pack_arguments, replaced thereturn_placeholderkwarg withis_external_call. WhenFalse, the signature is stored in memory.I had to adjust some memory offsets to make this work, but I think the resulting code is a bit cleaner.
How to verify it
Run the tests. I didn't add any cases, but I did confirm that we have sufficient coverage around this functionality.
Cute Animal Picture