Ease restrictions on self-call#2059
Merged
iamdefinitelyahuman merged 3 commits intoJun 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
- Coverage 85.06% 85.06% -0.01%
==========================================
Files 83 83
Lines 8115 8113 -2
Branches 1957 1956 -1
==========================================
- Hits 6903 6901 -2
Misses 730 730
Partials 482 482
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Jun 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Ease restrictions on a contract calling into itself:
selfCloses #1696
How I did it
vyper/parser/external_call.pyHow to verify it
Run the tests. I flipped a few tests around that were verifying this behavior wasn't working, now they check that it works.
Cute Animal Picture