Indexed array types#2060
Merged
iamdefinitelyahuman merged 3 commits intoJun 28, 2020
Merged
Conversation
fubuloubu
approved these changes
Jun 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Hash non-value types when they are used as indexed topics. Closes #1699
This introduces a significant change in that we no longer convert e.g.
bytes[1]tobytes1- bytes and string arrays are always represented asbytesandstringin the event ABI, regardless of length.We can now also support use of bytes or string arrays >32 bytes, and array types.
How I did it
In
vyper/parser/events.py, expanded the logic ofpack_event_topics.How to verify it
Run the tests. I had to modify quite a few based on this change, and I added some new cases to ensure that indexed topics are correct when reading variables from memory, storage, and calldata.
Cute Animal Picture