Check length of return data from external calls#2076
Merged
fubuloubu merged 5 commits intoJul 2, 2020
Conversation
39cf381 to
4e4e55c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
=======================================
Coverage 85.04% 85.05%
=======================================
Files 83 83
Lines 8239 8243 +4
Branches 1985 1987 +2
=======================================
+ Hits 7007 7011 +4
Misses 735 735
Partials 497 497
Continue to review full report at Codecov.
|
fubuloubu
reviewed
Jul 1, 2020
fubuloubu
approved these changes
Jul 2, 2020
c2befe9 to
fd56e7c
Compare
fubuloubu
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
bytesandstringdata does now have a length longer than the max allowed for the given type. Closes No length check on bytes and string arrays #1840How I did it
RETURNDATASIZE> expected length -1 after making a call.EXTCODESIZE. An address that is not a contract will not return any data, so this check isn't required.It is still possible for a call to return more data than expected by the interface. This is consistent with how Solidity handles the check.
How to verify it
Run the tests. I added a few test cases, and removed one that is no longer valid.
Cute Animal Picture