fix: adjust FuncionDef offset to not include decorators#2102
Merged
iamdefinitelyahuman merged 1 commit intoJul 6, 2020
Merged
Conversation
1092ce7 to
81cc458
Compare
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 83 83
Lines 8247 8251 +4
Branches 1990 1991 +1
=======================================
+ Hits 7010 7014 +4
Misses 740 740
Partials 497 497
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Jul 6, 2020
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
What about if someone puts a comment between the last decorator and the function def?
Contributor
Author
|
The only way to be more accurate is to look for the specific |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Adjust
FunctionDefoffset to not include decorators. This ensures a more readable annotation when an exception is raised.Before:
After:
How I did it
When converting from Python to Vyper AST, modify
FunctionDef.linenoto be +1 from theend_linenoof the final decorator.How to verify it
Run tests.
Cute Animal Picture