Array index typecheck#2108
Merged
fubuloubu merged 5 commits intoJul 16, 2020
Merged
Conversation
fubuloubu
approved these changes
Jul 15, 2020
Contributor
|
Add a test |
Contributor
|
This pull request introduces 1 alert when merging 431bde4 into d585a4c - view on LGTM.com new alerts:
|
iamdefinitelyahuman
force-pushed
the
fix-array-index-typecheck
branch
from
431bde4 to
f6d8513
Compare
Contributor
|
This pull request introduces 1 alert when merging f6d8513 into d585a4c - view on LGTM.com new alerts:
|
fubuloubu
approved these changes
Jul 16, 2020
After following the doc and executing brownie test, I faced an error: E brownie.exceptions.EventLookupError: Unknown key '_value' - the 'DataChange' event includes these keys: setter, value The error is quite explanatory, the event DataChange has been defined with keys `value` and `setter` and were being accessed in the test cases by `_value` and `_setter`. Thus the proposed change
iamdefinitelyahuman
force-pushed
the
fix-array-index-typecheck
branch
from
f6d8513 to
24b7a3d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
==========================================
- Coverage 85.02% 84.12% -0.91%
==========================================
Files 83 83
Lines 8261 8276 +15
Branches 1992 1994 +2
==========================================
- Hits 7024 6962 -62
- Misses 740 816 +76
- Partials 497 498 +1
Continue to review full report at Codecov.
|
Contributor
|
This pull request introduces 1 alert when merging 24b7a3d into 71568de - view on LGTM.com new alerts:
|
fubuloubu
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
__repr__to abstract types to improve readability of error messages.How I did it
When an index value is not a literal integer, call to
validate_expected_typeand expectIntegerAbstractTypeHow to verify it
Run tests.
Cute Animal Picture