fix: add trailing whitespace for EOF exception#2115
Merged
fubuloubu merged 1 commit intoJul 26, 2020
Conversation
Contributor
Author
|
@fubuloubu, this error was shown to me by a user that was dealing with a multiline EOF error as a result of a mismatched parenthesis. This fix will at least annotate the source, but it still points to the last character which isn't very useful. A better solution would be to track counts and offsets of |
fubuloubu
approved these changes
Jul 25, 2020
Contributor
|
🤷♂️ 🛳️🚀 |
|
NICE |
|
That's dope 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix a bug preventing annotation of end-of-file syntax errors
How I did it
Append
" "to source prior to annotation. The EOF error always points to one character beyond the length of the source, as this is the offset the error was encountered at.How to verify it
Try to compile an incomplete source.
Cute Animal Picture