Improved for loop TypeMismatch exception#2119
Merged
fubuloubu merged 4 commits intoJul 26, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2119 +/- ##
==========================================
- Coverage 85.01% 83.81% -1.21%
==========================================
Files 83 83
Lines 8288 8234 -54
Branches 2001 2002 +1
==========================================
- Hits 7046 6901 -145
- Misses 743 833 +90
- Partials 499 500 +1
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Jul 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Improve exception on a failed for loop type check.
How I did it
When the target value in a for loop has multiple potential types, and using each type creates a different
TypeMismatch, display all of the exceptions with an explanation as to what happened.To do so, I've modified the
nodesmember ofVyperExceptionto be calledannotations- it can now also be given as a tuple of("message", node). This lets us attach specific messages to each annotation. I think there will be other places this is useful in the future.How to verify it
Run tests.
Cute Animal Picture