ignore trailing newline tokens#2120
Merged
Merged
Conversation
fubuloubu
approved these changes
Jul 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When calculating the end offset for AST nodes, ignore trailing newlines.
How I did it
In some cases the final token given for an AST node is type 4, which is
\n. This makes for a weird source offset, and under very specific conditions is causing issues in Brownie.To fix it, I'm checking if the final token is
\nand if yes: -1 from the given offset.How to verify it
Run tests.
Cute Animal Picture