fixes: #2142#2143
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2143 +/- ##
=======================================
Coverage 84.95% 84.95%
=======================================
Files 83 83
Lines 8333 8333
Branches 2012 2012
=======================================
Hits 7079 7079
Misses 752 752
Partials 502 502
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Sep 4, 2020
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #2142
How I did it
vyper/vyper/parser/external_call.py
Line 92 in ce88755
Changed
types_list = output_type.memberstotypes_list = output_type.tuple_members(). In the case of struct,output_type.membersreturns a dict object, but types_list should be a list of typesHow to verify it
Runt the following test case