Optimization: division safemath when divisor is a literal#2173
Merged
fubuloubu merged 1 commit intoSep 29, 2020
Conversation
fubuloubu
approved these changes
Sep 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #2173 +/- ##
==========================================
+ Coverage 85.22% 85.23% +0.01%
==========================================
Files 83 83
Lines 8330 8336 +6
Branches 2009 2011 +2
==========================================
+ Hits 7099 7105 +6
Misses 731 731
Partials 500 500
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Remove the safemath check when dividing by a literal value.
How I did it
If the divisor is a literal, remove the
clamp_nonzeroinstruction within the LLL.How to verify it
Run tests.
Cute Animal Picture