Optimization for multiple memory-zeroing instructions#2174
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
+ Coverage 85.25% 85.29% +0.04%
==========================================
Files 83 83
Lines 8367 8397 +30
Branches 2019 2029 +10
==========================================
+ Hits 7133 7162 +29
Misses 732 732
- Partials 502 503 +1
Continue to review full report at Codecov.
|
9b47d4e to
e1c195f
Compare
fubuloubu
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add an optimization for zeroing multiple memory slots at once.
Closes #2144
How I did it
When the LLL contains multiple sequential instructions to
MSTORE n 0orCALLDATACOPY m CALLDATALSIZE n, and the locations being zero'd within memory are sequential, merge these instructions into a single zeroing via calldatacopy.How to verify it
Run tests.
Cute Animal Picture