Size limit optimizations#2175
Merged
iamdefinitelyahuman merged 5 commits intoSep 30, 2020
Merged
Conversation
Contributor
|
Really need to test this one across EVM versions. Does that happen? |
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
==========================================
+ Coverage 85.23% 85.25% +0.01%
==========================================
Files 83 83
Lines 8336 8367 +31
Branches 2011 2019 +8
==========================================
+ Hits 7105 7133 +28
- Misses 731 732 +1
- Partials 500 502 +2
Continue to review full report at Codecov.
|
2619435 to
774da04
Compare
fubuloubu
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Optimizations around size clamps.
How I did it
addressandboolusingshrinstead of a comparison to the in-memory size limit.mstoreoperation to reduce the size of the bytecode.How to verify it
Run tests.
Cute Animal Picture