Improve exception for incorrect arg count#2178
Merged
fubuloubu merged 3 commits intoOct 10, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
==========================================
- Coverage 85.32% 84.40% -0.93%
==========================================
Files 83 83
Lines 8403 8417 +14
Branches 2032 2038 +6
==========================================
- Hits 7170 7104 -66
- Misses 731 808 +77
- Partials 502 505 +3
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 4, 2020
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
A couple more branches need tests
458d2b2 to
42b55f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
==========================================
+ Coverage 85.36% 85.44% +0.07%
==========================================
Files 79 83 +4
Lines 8250 8445 +195
Branches 2010 2042 +32
==========================================
+ Hits 7043 7216 +173
- Misses 709 727 +18
- Partials 498 502 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Improve the annotation location and exception message when calling a function with an incorrect number of arguments.
Before:
After:
How I did it
Prior to raising the exception, look at the node in question and target one of it's descendants accordingly.
Cute Animal Picture