Refactor int128 clamps#2179
Merged
fubuloubu merged 3 commits intoOct 9, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
+ Coverage 85.32% 85.34% +0.01%
==========================================
Files 83 83
Lines 8403 8411 +8
Branches 2032 2033 +1
==========================================
+ Hits 7170 7178 +8
Misses 731 731
Partials 502 502
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
- Coverage 85.32% 85.24% -0.09%
==========================================
Files 83 79 -4
Lines 8403 8227 -176
Branches 2032 2006 -26
==========================================
- Hits 7170 7013 -157
+ Misses 731 714 -17
+ Partials 502 500 -2
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 9, 2020
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Refactor the process of clamping
int128using bitshifting.How I did it
The new check can be expressed as:
This check produces smaller bytecode and uses less gas at runtime.
The logic is handled in a new
int128_clampfunction withinvyper.parser.arg_clamps. All the locations where clamping previously happened are now calling to this function.How to verify it
Run the tests.
I still need to verify how well tested this behavior is.
Cute Animal Picture