fix-#2183: Incorrect output while passing multi-dimensional array as argument#2184
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2184 +/- ##
==========================================
- Coverage 85.32% 85.22% -0.10%
==========================================
Files 83 79 -4
Lines 8403 8219 -184
Branches 2032 2005 -27
==========================================
- Hits 7170 7005 -165
+ Misses 731 714 -17
+ Partials 502 500 -2
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed: #2183
How I did it
In this line it is assumed that size of each subtype of a array/struct is 32, which is wrong:
vyper/vyper/parser/parser_utils.py
Line 505 in 5115867
So I replaced the above line with this.
And since the variable count is not needed anymore we can avoid its calculation here:
vyper/vyper/parser/parser_utils.py
Line 501 in 5115867