Calculate array index offsets at compile time#2187
Merged
fubuloubu merged 1 commit intoOct 10, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2187 +/- ##
==========================================
- Coverage 85.36% 84.57% -0.80%
==========================================
Files 79 83 +4
Lines 8250 8446 +196
Branches 2010 2040 +30
==========================================
+ Hits 7043 7143 +100
- Misses 709 802 +93
- Partials 498 501 +3
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When accessing an array in memory, calculate the offset during compile-time instead of runtime.
How I did it
In
parser_utils, I added a private method_make_array_index_setterthat generates different LLL if the target value is in memory and the offset is fixed. I also avoid the use ofwithwhere possible, so no values are needlessly placed on the stack.How to verify it
Run the tests. I didn't add any new cases, but this behavior is well tested within the existing suite.
Cute Animal Picture