Improve exception for invalid use of dynamically sized struct#2189
Merged
fubuloubu merged 3 commits intoOct 10, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
=======================================
Coverage 85.49% 85.49%
=======================================
Files 83 83
Lines 8503 8517 +14
Branches 2056 2059 +3
=======================================
+ Hits 7270 7282 +12
- Misses 729 731 +2
Partials 504 504
Continue to review full report at Codecov.
|
fubuloubu
reviewed
Oct 10, 2020
63b5b00 to
2937303
Compare
fubuloubu
approved these changes
Oct 10, 2020
2937303 to
c4e5ffe
Compare
fubuloubu
approved these changes
Oct 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Raise
ArgumentExceptionwhen using a dynamically-sized struct as a function input.How I did it
is_dynamic_sizeattribute to all type objects withinvyper.contextHow to verify it
Run the tests. I added some new cases.
Cute Animal Picture