Merge Context.get_placeholder and Context.get_internal_variable#2194
Merged
fubuloubu merged 2 commits intoOct 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
==========================================
+ Coverage 85.45% 85.46% +0.01%
==========================================
Files 83 83
Lines 8505 8498 -7
Branches 2055 2052 -3
==========================================
- Hits 7268 7263 -5
+ Misses 734 733 -1
+ Partials 503 502 -1
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Merge
Context.get_placeholderandContext.get_internal_variableHow I did it
Both of these methods served an identical purpose and
get_internal_variablewas only used twice in the codebase. I've merged the logic into a single function and added docstrings to make it more clear what is happening.How to verify it
Run tests.
Cute Animal Picture