Assertion/revert optimizations#2198
Merged
iamdefinitelyahuman merged 4 commits intoOct 15, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
==========================================
- Coverage 85.30% 85.26% -0.04%
==========================================
Files 83 83
Lines 8524 8523 -1
Branches 2061 2063 +2
==========================================
- Hits 7271 7267 -4
- Misses 747 748 +1
- Partials 506 508 +2
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 15, 2020
fubuloubu
reviewed
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
LLL-level optimizations around assertions and reverts.
How I did it
revertmacro instead ofassertwhere possibleHow to verify it
Run tests.
Cute Animal Picture