Optimize shift when 2nd arg is a literal#2201
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2201 +/- ##
==========================================
+ Coverage 85.26% 85.27% +0.01%
==========================================
Files 83 83
Lines 8523 8529 +6
Branches 2063 2065 +2
==========================================
+ Hits 7267 7273 +6
Misses 748 748
Partials 508 508
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Optimize the LLL for
shiftwhen the distance being shifted is a literal.How I did it
Avoid pushing to the stack when not necessary.
How to verify it
Run tests. I didn't add any - the behaviour is already well tested.
Cute Animal Picture