raise warning when EIP-170 contract size limit is exceeded#2208
Merged
fubuloubu merged 1 commit intoOct 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
==========================================
+ Coverage 85.31% 85.36% +0.04%
==========================================
Files 83 84 +1
Lines 8525 8533 +8
Branches 2063 2064 +1
==========================================
+ Hits 7273 7284 +11
+ Misses 745 743 -2
+ Partials 507 506 -1
Continue to review full report at Codecov.
|
lr4d
force-pushed
the
raise_warning_on_contract_size_exceeded
branch
from
1e3a5ec to
bef27bd
Compare
fubuloubu
approved these changes
Oct 27, 2020
fubuloubu
left a comment
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Some minor nits
lr4d
force-pushed
the
raise_warning_on_contract_size_exceeded
branch
from
bef27bd to
b178353
Compare
Contributor
Author
Contributor
|
@lr4d thanks for seeing that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #2150
Still to-do according to #2150 (comment):
I'm not too familiar with the internals yet, so would appreciate suggestions on the suggestions to be provided.
How I did it
How to verify it
Description for the changelog
Cute Animal Picture