Explicitly disallow iteration of list of structs#2228
Merged
fubuloubu merged 2 commits intoNov 27, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2228 +/- ##
=======================================
Coverage 85.35% 85.36%
=======================================
Files 84 84
Lines 8536 8539 +3
Branches 2062 2063 +1
=======================================
+ Hits 7286 7289 +3
Misses 744 744
Partials 506 506
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Explicitly disallow iteration of a list of structs
Fixes #2223
How I did it
Add a check within the type checking pass. This behaviour is disallowed in parser, but without the exception in type checking it raises a
CompilerPanicHow to verify it
Run the tests. I added a new test to verify this behavior.
Cute Animal Picture