Add support for not in comparator#2232
Merged
iamdefinitelyahuman merged 3 commits intoNov 28, 2020
Merged
Conversation
fubuloubu
reviewed
Nov 27, 2020
iamdefinitelyahuman
force-pushed
the
feat-notin
branch
from
863cf73 to
12cdc20
Compare
fubuloubu
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add support for the
not incomparatorCloses #2218
How I did it
NotInast nodeparserto supportnot inHow to verify it
Run the tests. I added some new cases to test this behaviour.
Cute Animal Picture