Fix: empty static-sized arrays within log statement#2235
Merged
Conversation
iamdefinitelyahuman
changed the title
empty static-sized arrays within log statement
iamdefinitelyahuman
force-pushed
the
fix-empty-events
branch
from
c59748f to
4347d4a
Compare
iamdefinitelyahuman
force-pushed
the
fix-empty-events
branch
from
4347d4a to
e6c6168
Compare
fubuloubu
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Allow use of
emptywith static-sized arrays, inside an event logging statement.Closes #2158
How I did it
Expanded logic in
parser.events- this is very similar to logic in #2234How to verify it
Run tests. I added some cases.
Cute Animal Picture