Consider events during type-check "implements:"#2283
Merged
iamdefinitelyahuman merged 4 commits intoJan 24, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2283 +/- ##
==========================================
- Coverage 85.44% 85.37% -0.08%
==========================================
Files 84 84
Lines 8591 8614 +23
Branches 2075 2083 +8
==========================================
+ Hits 7341 7354 +13
- Misses 748 756 +8
- Partials 502 504 +2
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Jan 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
During type checking. consider events when validating the
implementsstatement.How I did it
Expand the existing code for
implements- most of the logic is just ported over from how we check functions.How to verify it
Verify the test suite is still passing. This is already very well tested so I have not added further cases.
Cute Animal Picture