Streamlined ABI encoder logic for returning tuple types#2302
Merged
fubuloubu merged 2 commits intoFeb 16, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
- Coverage 85.84% 85.81% -0.04%
==========================================
Files 85 85
Lines 8539 8556 +17
Branches 2034 2040 +6
==========================================
+ Hits 7330 7342 +12
- Misses 727 730 +3
- Partials 482 484 +2
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Simplify the logic around returning tuples, when each member of the tuple is of the same type.
How I did it
Add a special
ifbranch that replicates the logic for returning an array type. This branch is only reached if every member of the tuple has the same type, and that type is a base type (or array of the base type).This has a not-insignificant effect on the bytecode size.
How to verify it
Run tests (TODO)
Cute Animal Picture
Cute aminals are for closers.