Reorder functions within the bytecode#2303
Merged
fubuloubu merged 6 commits intoFeb 16, 2021
Merged
Conversation
fa7c8ba to
a7b05fc
Compare
c22c081 to
095d5f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2303 +/- ##
==========================================
- Coverage 85.82% 85.79% -0.04%
==========================================
Files 85 85
Lines 8546 8549 +3
Branches 2036 2039 +3
==========================================
Hits 7335 7335
- Misses 728 730 +2
- Partials 483 484 +1
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Reorder functions within the bytecode and refactor how the function selector is checked.
How I did it
Functions were previous sequenced in the same way as they are found in the source. Internal functions were jumped over following an inefficient
PUSH1 0x0 ISZEZOcheck.This PR places all internal functions after the fallback, so they cannot be reached without being explicitely jumped to from an internal function. Thus, all the jumping logic can be removed and the bytecode size reduced.
The function selector itself was previous written to memory with offset 0, and loaded onto the stack for every comparison. This PR modifies the process so that the selector is kept on the stack and compared via
DUPoperations rather than repeatedMLOAD. Less bytecode, less gas.How to verify it
Run the tests, see that nothing has broken.
Cute Animal Picture
Coming soon