Assembly-level optimizations#2304
Merged
fubuloubu merged 2 commits intoFeb 15, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2304 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.02%
==========================================
Files 85 85
Lines 8546 8560 +14
Branches 2036 2042 +6
==========================================
+ Hits 7335 7346 +11
- Misses 728 730 +2
- Partials 483 484 +1
Continue to review full report at Codecov.
|
iamdefinitelyahuman
force-pushed
the
optimize-assembly
branch
from
ec4b289 to
a6b4fab
Compare
iamdefinitelyahuman
force-pushed
the
optimize-assembly
branch
from
a6b4fab to
902b7b2
Compare
fubuloubu
approved these changes
Feb 15, 2021
fubuloubu
left a comment
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
Big change, but if it passes the test suite, hopefully should work just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
Added some logic in
assembly_to_evmwithincompile_lll.pyBoth of these situations occur as a result of LLL generation happening in small chunks that don't see the "bigger picture" around them. There is likely a more elegant solution here, but this is effective and simple to implement. I've left comments about what's happening, we can try to address this properly as we refactor out
parserin the future and give ourselves more effective data structures to catch and fix this as it happens rather than after the fact.How to verify it
Run tests, confirm that nothing broke. If this created any issues we'd see tests failing everywhere, especially within the e2e tests of the examples.
Cute Animal Picture
Notice me senpai!