Document the webdriver command to use another account.#752
Open
cbiesinger wants to merge 1 commit intow3c-fedid:mainfrom
Open
Document the webdriver command to use another account.#752cbiesinger wants to merge 1 commit intow3c-fedid:mainfrom
cbiesinger wants to merge 1 commit intow3c-fedid:mainfrom
Conversation
npm1
reviewed
Jun 24, 2025
| 1. Act as if the user had triggered the "Use another account" affordance | ||
| and initiate the [=IDP=] login flow as described above. | ||
|
|
||
| Note: Because multiple IDPs are only supported in passive mode, and |
Collaborator
There was a problem hiding this comment.
Hmm should this command have an IDP for logging in though? Otherwise how do you know which IDP to log in to for the dialog in 2668?
Collaborator
Author
There was a problem hiding this comment.
As the note says, there can only be one IDP
If we support the combination of use other account and multiple IDPs at some point, we can add an index parameter similar to what https://github.com/w3c-fedid/FedCM/pull/610/files was trying to do.
Collaborator
Author
There was a problem hiding this comment.
And the case on line 2668 is pre-existing, just reformatted basically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff