Skip to content

SPARQL 1.1: REPLACE: cover regex options#268

Merged
Tpt merged 3 commits intomainfrom
tpt/replace
Jan 9, 2026
Merged

SPARQL 1.1: REPLACE: cover regex options#268
Tpt merged 3 commits intomainfrom
tpt/replace

Conversation

@Tpt
Copy link
Copy Markdown
Contributor

@Tpt Tpt commented Dec 26, 2025

Use only 'i', REGEX covers regex options in details

Use only 'i', REGEX covers regex options in details
@Tpt Tpt requested review from afs and rubensworks December 26, 2025 19:06
@Tpt Tpt self-assigned this Dec 26, 2025
@Tpt Tpt mentioned this pull request Dec 26, 2025
40 tasks
Copy link
Copy Markdown
Contributor

@afs afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion (not required) to emphasis the change.

Comment thread sparql/sparql11/functions/replace-case-insensitive.rq Outdated
@Tpt Tpt merged commit a1de58c into main Jan 9, 2026
1 check passed
@Tpt Tpt deleted the tpt/replace branch January 9, 2026 15:57
@kasei
Copy link
Copy Markdown
Contributor

kasei commented Jan 9, 2026

Oops. I waited too long. After seeing this this morning, I was wondering if it should cover more than just the i flag. Maybe I'll try to create a new issue/PR.

@Tpt
Copy link
Copy Markdown
Contributor Author

Tpt commented Jan 10, 2026

I was wondering if it should cover more than just the i flag. Maybe I'll try to create a new issue/PR.

Would be nice but imho low priority: they are already covered in REGEX. I would prefer to have first tests for the features of the regex syntax (coverage is very spotty and a lot of implementations are green even if they do not implement the full XSD regex syntax).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants