Skip to content

update react canary version#138

Merged
dai-shi merged 8 commits intomainfrom
add-form-example
Oct 24, 2023
Merged

update react canary version#138
dai-shi merged 8 commits intomainfrom
add-form-example

Conversation

@dai-shi
Copy link
Copy Markdown
Member

@dai-shi dai-shi commented Oct 17, 2023

  • update react canary version
  • fix using decodeReply outside "react-server" condition
  • add 11_form example

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 11:58pm

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Oct 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18147fa:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@dai-shi dai-shi changed the title add form example update react canary version Oct 18, 2023
@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Oct 18, 2023

Oh, no. facebook/react#27436 prevents to use decodeReply outside "react-server" condition. 😱

@dai-shi dai-shi marked this pull request as ready for review October 24, 2023 00:00
@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Oct 24, 2023

It was far bigger change than I expected. Merging.

@dai-shi dai-shi merged commit c59413d into main Oct 24, 2023
@dai-shi dai-shi deleted the add-form-example branch October 24, 2023 00:03
himself65 added a commit to himself65/waku that referenced this pull request Oct 24, 2023
* update react canary version

* fix package.json

* send stream to worker

* hack ssr manifest

* test all examples

* add 11_form

* ah, i see... this is confusing
@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Oct 24, 2023

18147fa

this is confusing

ah, the form status is only available in the form tree. makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant