This repository was archived by the owner on Mar 20, 2021. It is now read-only.
Success handler of fetch is not called when response is synchronous (and fetchQueue is empty)#378
Open
MichaReiser wants to merge 1 commit intowalmartlabs:masterfrom
Open
Success handler of fetch is not called when response is synchronous (and fetchQueue is empty)#378MichaReiser wants to merge 1 commit intowalmartlabs:masterfrom
MichaReiser wants to merge 1 commit intowalmartlabs:masterfrom
Conversation
Contributor
Author
|
I have added a unit test that shows the issue. Either I still don't know how a fix can be implemented. |
Contributor
|
I'm facing the same issue, any progress on that? |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the fetchQueue method a new queue is created when no one exists. Additionally the success and error callbacks are overridden to point to flushQueue. When super ($super.call) is called, the fetch queue is still empty. When the super.call now resolves the success handler synchronous (no defer or anything), then at the moment where flushQueue is called, the queue is still empty, and the success or error handler are not called (because the queue is empty)
A simple solution could be, that super will be invoked using _.defer. Otherwise the registration in the flushQueue must take place before invoking super...