feat: add initial Kotlin setup with main function and build configura…#1598
feat: add initial Kotlin setup with main function and build configura…#1598SuperBatata wants to merge 44 commits intomainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughA new module "waltid-openid4vci-wallet" is added to the build system under the protocols library group. The module includes standard Gradle build configuration with Kotlin JVM support and a basic main entry point. Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@waltid-libraries/protocols/waltid-openid4vci-wallet/build.gradle.kts`:
- Around line 1-18: The build applies kotlin("jvm") with a hardcoded version;
replace that by applying the project's convention plugin id "waltid.jvm.library"
so the module inherits the shared Java toolchain, Kotlin serialization,
power-assert test support and standardized JUnit Platform config used by sibling
protocol modules; update the plugins block to remove kotlin("jvm") and
apply("waltid.jvm.library") and remove any now-unnecessary explicit Kotlin
version or duplicated test/JUnit configuration to keep consistency with the
project conventions.
In `@waltid-libraries/protocols/waltid-openid4vci-wallet/src/main/kotlin/Main.kt`:
- Around line 1-16: This file contains IDE boilerplate and a placeholder main()
that should not be committed; either delete Main.kt if the library module is not
runnable, or replace it with a meaningful entry point/API implementation and
update the package to a module-specific name (e.g., change package id.waltid to
id.waltid.openid4vci.wallet). Locate the top-level main() function and the
package declaration in Main.kt, remove all IDE TIP comments and the placeholder
code if deleting, or refactor main() into the real entry logic and set the new
package declaration to avoid the generic id.waltid namespace.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 50257175-f0b8-4148-a07f-7d78f90bdf67
📒 Files selected for processing (3)
settings.gradle.ktswaltid-libraries/protocols/waltid-openid4vci-wallet/build.gradle.ktswaltid-libraries/protocols/waltid-openid4vci-wallet/src/main/kotlin/Main.kt
waltid-libraries/protocols/waltid-openid4vci-wallet/src/main/kotlin/Main.kt
Show resolved
Hide resolved
…fferedCredentialResolver for OpenID4VCI credential handling
…d authorization server metadata
…ID4VCI credential proof generation
…nd CSRF protection
…ests in OpenID4VCI
…h code challenge methods
…to feature/wal-659
…to feature/wal-659
…ing for token response
…thorizationRequest` serializable
…g, credential parsing, and URI validation
…resolution and improve fallback logic for authorization server resolution
…d error handling
… metadata resolution logic, and improve logging
|



This pull request introduces a new module to the project for OpenID4VCI wallet functionality. The main changes include adding the new module to the project configuration, setting up its build configuration, and providing a basic Kotlin entry point.
New OpenID4VCI wallet module:
Project configuration:
waltid-openid4vci-walletto the list of modules insettings.gradle.kts, ensuring it is included in the build.Build setup:
build.gradle.ktsforwaltid-openid4vci-walletwith Kotlin JVM plugin, dependencies, and test configuration.Summary by CodeRabbit
New Features
Chores