Skip to content

feat: add initial Kotlin setup with main function and build configura…#1598

Draft
SuperBatata wants to merge 44 commits intomainfrom
feature/wal-659
Draft

feat: add initial Kotlin setup with main function and build configura…#1598
SuperBatata wants to merge 44 commits intomainfrom
feature/wal-659

Conversation

@SuperBatata
Copy link
Copy Markdown
Contributor

@SuperBatata SuperBatata commented Mar 11, 2026

This pull request introduces a new module to the project for OpenID4VCI wallet functionality. The main changes include adding the new module to the project configuration, setting up its build configuration, and providing a basic Kotlin entry point.

New OpenID4VCI wallet module:

  • Project configuration:

    • Added waltid-openid4vci-wallet to the list of modules in settings.gradle.kts, ensuring it is included in the build.
  • Build setup:

    • Created a new build.gradle.kts for waltid-openid4vci-wallet with Kotlin JVM plugin, dependencies, and test configuration.

Summary by CodeRabbit

  • New Features

    • Groundwork added for OpenID4VCI wallet protocol support, establishing foundation for future wallet capabilities
  • Chores

    • Established build configuration and project infrastructure for new wallet protocol module
    • Integrated new OpenID4VCI wallet module into the project build system with necessary dependencies and testing framework configuration

@linear
Copy link
Copy Markdown

linear bot commented Mar 11, 2026

@SuperBatata SuperBatata self-assigned this Mar 11, 2026
@SuperBatata SuperBatata marked this pull request as draft March 11, 2026 09:32
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b08c660b-736a-4957-b4e8-a0fee6bd9c5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

A new module "waltid-openid4vci-wallet" is added to the build system under the protocols library group. The module includes standard Gradle build configuration with Kotlin JVM support and a basic main entry point.

Changes

Cohort / File(s) Summary
Module Setup
settings.gradle.kts, waltid-libraries/protocols/waltid-openid4vci-wallet/build.gradle.kts
Registers new module in build system and configures Gradle with Kotlin JVM plugin (2.3.10), group id.waltid, version 1.0.0-SNAPSHOT, mavenCentral repository, and Kotlin test dependency with JUnit Platform.
Entry Point
waltid-libraries/protocols/waltid-openid4vci-wallet/src/main/kotlin/Main.kt
Adds new Kotlin main function that prints a greeting message and loops through values 1-5.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the key changes and new module addition, but lacks completion of the required template sections (Type of Change and Checklist). Complete the template by selecting the appropriate type of change (e.g., 'new feature') and checking off the relevant checklist items to confirm code review, testing, and documentation status.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding initial Kotlin setup with main function and build configuration for a new module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@waltid-libraries/protocols/waltid-openid4vci-wallet/build.gradle.kts`:
- Around line 1-18: The build applies kotlin("jvm") with a hardcoded version;
replace that by applying the project's convention plugin id "waltid.jvm.library"
so the module inherits the shared Java toolchain, Kotlin serialization,
power-assert test support and standardized JUnit Platform config used by sibling
protocol modules; update the plugins block to remove kotlin("jvm") and
apply("waltid.jvm.library") and remove any now-unnecessary explicit Kotlin
version or duplicated test/JUnit configuration to keep consistency with the
project conventions.

In `@waltid-libraries/protocols/waltid-openid4vci-wallet/src/main/kotlin/Main.kt`:
- Around line 1-16: This file contains IDE boilerplate and a placeholder main()
that should not be committed; either delete Main.kt if the library module is not
runnable, or replace it with a meaningful entry point/API implementation and
update the package to a module-specific name (e.g., change package id.waltid to
id.waltid.openid4vci.wallet). Locate the top-level main() function and the
package declaration in Main.kt, remove all IDE TIP comments and the placeholder
code if deleting, or refactor main() into the real entry logic and set the new
package declaration to avoid the generic id.waltid namespace.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 50257175-f0b8-4148-a07f-7d78f90bdf67

📥 Commits

Reviewing files that changed from the base of the PR and between 8e30332 and 307f25a.

📒 Files selected for processing (3)
  • settings.gradle.kts
  • waltid-libraries/protocols/waltid-openid4vci-wallet/build.gradle.kts
  • waltid-libraries/protocols/waltid-openid4vci-wallet/src/main/kotlin/Main.kt

…fferedCredentialResolver for OpenID4VCI credential handling
…resolution and improve fallback logic for authorization server resolution
… metadata resolution logic, and improve logging
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant