Feature/wal 864 client attestation by philpotisk · Pull Request #1649 · walt-id/waltid-identity

philpotisk · 2026-04-09T12:40:44Z

No description provided.

…tion

…l-659

…ion requests

…fferedCredentialResolver for OpenID4VCI credential handling

…d authorization server metadata

…ID4VCI credential proof generation

…nd CSRF protection

…ests in OpenID4VCI

…h code challenge methods

…lver

…wal-659

…to feature/wal-659

…le` annotations

…annotations

…adataResolver`

…notations

…r logging

…ing for token response

…thorizationRequest` serializable

…g, credential parsing, and URI validation

…resolution and improve fallback logic for authorization server resolution

…d error handling

…l-659

…ields

…l-659

…e` annotation

…stBuilder`

… metadata resolution logic, and improve logging

…erprise)

…lient-attestation

…for attestation-based client auth Adds Map<String, String> additionalParameters param (default emptyMap()) to TokenRequestBuilder.exchangePreAuthorizedCode so callers can inject client_assertion / client_assertion_type for attestation-based client auth (draft-ietf-oauth-attestation-based-client-auth-08) without a separate overload.

coderabbitai · 2026-04-09T12:40:55Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 96bce515-97d0-400d-8478-2c4f582ff6c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…lUrl' field

…calUrl

sonarqubecloud · 2026-04-10T14:30:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SuperBatata added 30 commits March 11, 2026 10:30

feat: add initial Kotlin setup with main function and build configura…

307f25a

…tion

Merge remote-tracking branch 'origin/feat/issuer-lib' into feature/wa…

d54efb6

…l-659

feat: implement AuthorizationRequestBuilder for OpenID4VCI authorizat…

0452665

…ion requests

feat: add ClientConfiguration data class for OAuth 2.0 client setup

c4d7d80

feat: implement CredentialOfferParser, CredentialOfferResolver, and O…

16ee086

…fferedCredentialResolver for OpenID4VCI credential handling

feat: add IssuerMetadataResolver for fetching and resolving issuer an…

1a6098a

…d authorization server metadata

feat: implement JwtProofBuilder and ProofOfPossessionBuilder for Open…

250d726

…ID4VCI credential proof generation

feat: implement StateManager for managing OAuth 2.0 state parameter a…

ac32de6

…nd CSRF protection

feat: implement TokenRequestBuilder for handling OAuth 2.0 token requ…

4a1c763

…ests in OpenID4VCI

feat: implement PKCEManager for OAuth 2.0 authorization code flow wit…

a000d9e

…h code challenge methods

feat: add unit tests for CredentialOfferParser and IssuerMetadataReso…

d22a842

…lver

feat: add ktor-client-mock dependency for enhanced testing capabilities

16f8696

feat: add README.md for walt.id OpenID4VCI Wallet Library documentation

9cc304f

Merge remote-tracking branch 'refs/remotes/origin/main' into feature/…

877cda4

…wal-659

Merge remote-tracking branch 'refs/remotes/origin/feat/issuer-lib' in…

7fd569e

…to feature/wal-659

feat: add SLF4J simple implementation for improved logging

83f02ed

Merge remote-tracking branch 'refs/remotes/origin/feat/issuer-lib' in…

3b8bcc8

…to feature/wal-659

feat: make Client a sealed and serializable interface

1fc3450

feat: make CredentialRequest a sealed and serializable interface

97437b6

feat: make CredentialResponse and IssuedCredential serializable

243c012

feat: make DefaultCredentialRequest serializable using `@Serializab…

8d52382

…le` annotations

feat: make GrantType sealed and serializable using @Serializable …

4f32927

…annotations

feat: add fallback URL handling for metadata resolution in `IssuerMet…

8d7d4c7

…adataResolver`

feat: make OAuthError serializable using @Serializable annotation

fe1015f

feat: make Proofs serializable using @Serializable annotations

38f62d9

feat: make Session sealed and serializable using @Serializable an…

3b17f4c

…notations

Refactor metadata resolution methods to improve URL handling and erro…

68e1576

…r logging

Refactor TokenRequestBuilder: Remove unused fields and add debug logg…

de51bf0

…ing for token response

feat: enhance AuthorizationRequestBuilder with logging and make `Au…

89ba905

…thorizationRequest` serializable

Refactor CredentialOfferResolver: Improve logging for error handlin…

af40f25

…g, credential parsing, and URI validation

SuperBatata and others added 16 commits March 27, 2026 10:51

Refactor IssuerMetadataResolver: Add detailed logging for metadata …

1b28d46

…resolution and improve fallback logic for authorization server resolution

feat: make PKCEData serializable using @Serializable annotation

914e3c6

Refactor TokenRequestBuilder: Improve logging for token exchange an…

d302dde

…d error handling

Merge remote-tracking branch 'origin/feat/issuer-lib' into feature/wa…

d3cadaa

…l-659

feat: extend TokenRequest with c_nonce and c_nonce_expires_in f…

8b8f6ce

…ields

Merge remote-tracking branch 'origin/feat/issuer-lib' into feature/wa…

c1e5ed0

…l-659

Merge branch 'main' into feature/wal-659

f1dfdee

Merge remote-tracking branch 'origin/feature/wal-659' into feature/wa…

45d2564

…l-659

feat: make ResolvedCredentialOffer serializable using `@Serializabl…

119b803

…e` annotation

feat: add customizable redirectUri parameter to `AuthorizationReque…

8cbbc56

…stBuilder`

Refactor IssuerMetadataResolver: Update API paths to /v2/, adjust…

6590238

… metadata resolution logic, and improve logging

Merge remote-tracking branch 'origin/main' into feature/wal-659

9ad6c13

Changed common port in test

12aa1c6

fix: include waltid-openid4vci-wallet in module list (required by ent…

fdfc0ae

…erprise)

Merge branch 'demo/es-vical-x509-integrations' into feature/wal-864-c…

0669dff

…lient-attestation

walt-id deleted a comment from linear bot Apr 9, 2026

philpotisk added 2 commits April 10, 2026 09:41

feat(vical-policy): support http(s) URL as VICAL source via new 'vica…

eb9249a

…lUrl' field

feat(vical-policy): auto-detect hex vs CBOR response when fetching vi…

0df1eef

…calUrl

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/wal 864 client attestation#1649

Feature/wal 864 client attestation#1649
philpotisk wants to merge 48 commits intomainfrom
feature/wal-864-client-attestation

philpotisk commented Apr 9, 2026

Uh oh!

coderabbitai bot commented Apr 9, 2026 •

edited

Loading

Review skipped

Uh oh!

sonarqubecloud bot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

philpotisk commented Apr 9, 2026

Uh oh!

coderabbitai bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

sonarqubecloud bot commented Apr 10, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Apr 9, 2026 •

edited

Loading