Prevent subprocesses from trying to delete PID file#1836
Merged
albertomn86 merged 2 commits into3.7from Nov 8, 2018
Merged
Conversation
albertomn86
approved these changes
Nov 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix this error:
Daemons register a trigger to clean up their PID file before exiting (with
atexit()). When a process is forked, it inherits its parent's functions. If a module fails to execute an external program after forking, the child process exits as a wazuh-modulesd process, this makes the process delete its PID file, but, since it's a subprocess, there is no PID file for it.