Fix bug configuring empty blocks in FIM#1897
Merged
Conversation
0319e4b to
89139b0
Compare
Member
|
Syscheck and Rootcheck now have different behaviors: <rootcheck>
<disabled>yes</disabled>
</rootcheck>
<rootcheck />The second definition re-enables Rootcheck despite the first definition explicitly disables it. <syscheck>
<!--
<disabled>no</disabled>
-->
<directories check_all="yes" realtime="yes">/root/test</directories>
</syscheck>Syscheck is disabled because it was not explicitly enabled. Change proposalBoth Syscheck and Rootcheck may have this behavior:
|
89139b0 to
aea25eb
Compare
aea25eb to
a8ba11e
Compare
If no component stanza defined, keep disabled. If component stanza defined but no disabled tag defined, keep enabled.
vikman90
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue:
When defining a second FIM configuration block, if it is empty, the module is disabled. If the agent in question had different configurations because it belonged to several groups, the last block would make the rest of the applied configurations unusable. This PR solve this behavior.
Tests