Conversation
vikman90
force-pushed
the
dev-dep-remove-old-diff
branch
from
a058f58 to
ca7b856
Compare
vikman90
requested changes
Nov 22, 2018
Member
vikman90
left a comment
vikman90
left a comment
There was a problem hiding this comment.
BTW this issue also needs documentation.
| const char *xml_auto_ignore = "auto_ignore"; | ||
| const char *xml_alert_new_files = "alert_new_files"; | ||
| const char *xml_remove_old_diff = "remove_old_diff"; | ||
| const char *xml_remove_old_diff = "remove_old_diff"; // Deprecated since 3.7.1 |
| merror(XML_VALUEERR, node[i]->element, node[i]->content); | ||
| return (OS_INVALID); | ||
| } | ||
| //Deprecated since 3.7.1, aplied by default... |
vikman90
approved these changes
Nov 22, 2018
chemamartinez
added a commit
that referenced
this pull request
Nov 23, 2018
chemamartinez
added a commit
that referenced
this pull request
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues:
The option <remove_old_diff> is disabled. It becomes a mandatory behavior. In case that for old configurations it appears no warn message is shown, simply continues the execution.
Test:
report_changesis correct. The files are deleted when: