Agent config regex fix#2036
Merged
chemamartinez merged 5 commits into3.8from Dec 7, 2018
Merged
Conversation
vikman90
reviewed
Dec 6, 2018
Member
There was a problem hiding this comment.
Why is this value 20479 and not 20480?
Member
There was a problem hiding this comment.
Can we drop these changes off the PR?
vikman90
requested changes
Dec 7, 2018
Member
vikman90
left a comment
vikman90
left a comment
There was a problem hiding this comment.
Please add this limit checking to all the agent options:
<agent_config name><agent_config os><agent_config profile>
All they have the same limit problem.
Thanks!
Member
There was a problem hiding this comment.
Please let the log show the current option size. For instance:
Agent name filter (38291 bytes) exceeds the limit (20480).
Change in regex field maximum size
- Extend the limit check to agent profile and OS - Change maximum value to 20480 - Change warning description
chemamartinez
force-pushed
the
agent-config-regex-fix
branch
from
82816a8 to
58e1f20
Compare
vikman90
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to #1925