Fix crash in Modulesd when parsing command with missing tag#2470
Merged
chemamartinez merged 1 commit into3.8from Jan 28, 2019
Merged
Fix crash in Modulesd when parsing command with missing tag#2470chemamartinez merged 1 commit into3.8from
chemamartinez merged 1 commit into3.8from
Conversation
Tags must be compared when filled only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described by Valgrind, Modulesd compares the tag of every module to find duplicates and remove one of them.
There is a special case: commands with no tag. They are unique, no internal tag is defined so they must never be removed.
Fix
Tags must be compared when filled only: test that both strings are set before comparing them.