Fix memory error in agents on Windows XP when receiving a WPK file#2486
Merged
Fix memory error in agents on Windows XP when receiving a WPK file#2486
Conversation
This will prevent the agent from crasing on low memory error.
strlen() seems to fail when reading 3-byte data blocks. Fix: replace message "ok" with "ok ".
vikman90
added
type/bug
snaow
approved these changes
Jan 30, 2019
albertomn86
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agentclass)This PR applies the fix proposal described at #2467 (comment).
It also replaces
strdup()withos_strdup()in the command request dispatching library, in order to prevent uncontrolled crashes due to low memory.