Fix unrecognizable characters error in Windows version name#478
Merged
Fix unrecognizable characters error in Windows version name#478
Conversation
vikman90
approved these changes
Mar 23, 2018
vikman90
force-pushed
the
fix-windows-distributions
branch
from
1bd68f5 to
32ed93c
Compare
vikman90
force-pushed
the
fix-windows-distributions
branch
from
32ed93c to
3644547
Compare
Member
|
GJ @albertomn86 !! This fixes many recurring problems! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows version name extraction was failing in non-english versions (#436).
Now this issue is solved.