Disconnected time in ossec-agentd.state (max_time_reconnect_try)

[pereyra-m]

Related issue
#5138

Description

After replacing the notify_time variable with max_time_reconnect_try, it is possible to note that the file ossec-agentd.state is displaying the correct disconnected time.

Closes #5138

ossec-agentd.state file

This is an example of the file ossec-agentd.state when the bug appeared. It can be noted that both connected and disconnected time have the same value

# Agent status:
# - pending:      waiting for get connected.
# - connected:    connection established with manager in the last 5 seconds.
# - disconnected: connection lost or no ACK received in the last 5 seconds. 

After replacing the variable, the ossec-agentd.state file show the correct values for both times

# Agent status:
# - pending:      waiting to get connected.
# - connected:    connection established with manager in the last 10 seconds.
# - disconnected: connection lost or no ACK received in the last 60 seconds.

Tests

• Compilation without warnings in every supported platform
  • Linux
  • Windows
  • MAC OS X
• Source installation
• Package installation
• Source upgrade
• Package upgrade
• Review logs syntax and correct language
• QA templates contemplate the added capabilities

• Memory tests for Linux
  • Scan-build report
  • Coverity
  • Valgrind (memcheck and descriptor leaks check)
  • Dr. Memory
  • AddressSanitizer
• Memory tests for Windows
  • Scan-build report
  • Coverity
  • Dr. Memory
• Memory tests for macOS
  • Scan-build report
  • Leaks
  • AddressSanitizer

• Retrocompatibility with older Wazuh versions
• Working on cluster environments
• Configuration on demand reports new parameters
• The data flow works as expected (agent-manager-api-app)
• Added unit tests (for new features)
• Stress test for affected components

[wazuhci]

Analysis_dynamic_valgrind logcollector analysis:

Commit: 5103f0a
Parameters: track-origins="yes" leak-check="full" keep-stacktraces="alloc-and-free" track-fds="yes" num-callers="20" show-leak-kinds="definite,indirect"
Agent config: ossec.conf
Agent logs: ossec.log
Coverage:

Lines executed:31.41% of 1859

Coverage report detail: coverage-report-summary
Valgrind result: Analysis_dynamic_valgrind-v3.13.0-B2361.log

[wazuhci]

Analysis_dynamic_valgrind syscheckd analysis:

Commit: 5103f0a
Parameters: track-origins="yes" leak-check="full" keep-stacktraces="alloc-and-free" track-fds="yes" num-callers="20" show-leak-kinds="definite,indirect"
Agent config: ossec.conf
Agent logs: ossec.log
Coverage:

Lines executed:26.90% of 3190

Coverage report detail: coverage-report-summary
Valgrind result: Analysis_dynamic_valgrind-v3.13.0-B2362.log

[vikman90]

LGTM!