Fix NVD version comparator to remove undesired suffixes#5362
Merged
chemamartinez merged 4 commits into4.0-vdt-tmpfrom Jul 8, 2020
Merged
Fix NVD version comparator to remove undesired suffixes#5362chemamartinez merged 4 commits into4.0-vdt-tmpfrom
chemamartinez merged 4 commits into4.0-vdt-tmpfrom
Conversation
TomasTurina
reviewed
Jun 30, 2020
| if ((a[i] == '.' | ||
| || a[i] == '~' | ||
| || a[i] == '+') | ||
| && !c_isdigit(a[i + 1])) { |
Member
There was a problem hiding this comment.
What if there is a number after a ~ or a +?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the way that the version part is compared between the installed packages and the NVD packages for Linux. Since the NVD contains a generic version in most of the cases, the version of the installed package should be truncated in the following cases:
.followed by a non-numeric character+followed by a non-numeric character~followed by a non-numeric characterFinally, the following cases have been ignored for this change:
.0at the end of the version: In this case, the comparator itself has to compare the versions properly.openssl 1.1.0h): In these cases, the version found in the NVD generally contains those characters.Logs/Alerts example
Here an example of the comparison affected by this change:
Tests