Vulnerability-detector: Fix support for recent Windows Server versions#5524
Merged
chemamartinez merged 3 commits intodevelopfrom Aug 3, 2020
Merged
Vulnerability-detector: Fix support for recent Windows Server versions#5524chemamartinez merged 3 commits intodevelopfrom
chemamartinez merged 3 commits intodevelopfrom
Conversation
0xN3utr0n
changed the title
0xN3utr0n
force-pushed
the
4468_winserver_msu_request
branch
from
2406c55 to
48e69a3
Compare
0xN3utr0n
force-pushed
the
4468_winserver_msu_request
branch
from
d46fab2 to
48e69a3
Compare
chemamartinez
suggested changes
Jul 31, 2020
chemamartinez
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation treats
Win2016andWin2019agents as if they wereWin10. That is, vuln-detector isn't capable of detecting specific vulnerabilities for this operating system.We just need to restrict the Windows10 "special" treatment to those agents which use
FEED_WIN10.Additionally, and perhaps even more important, a second bug has been fixed. Hotfixes that were
superof other patches weren't treated as individual patches; thus false-negatives could appear if a CVE was fixed only by asuperpatch.Tests
Compilation without warnings in every supported platform
Source installation
Package installation
Source upgrade
Package upgrade
Checked the generated alerts for: