Skip to content

Fix verify agent configuration tool using patterns in FIM directories.#6187

Merged
vikman90 merged 4 commits intomasterfrom
fim-fix-verify-conf
Nov 20, 2020
Merged

Fix verify agent configuration tool using patterns in FIM directories.#6187
vikman90 merged 4 commits intomasterfrom
fim-fix-verify-conf

Conversation

@bah07
Copy link
Copy Markdown
Contributor

@bah07 bah07 commented Oct 3, 2020

Related issue
#167

Description

This PR solves a problem when checking the configuration with the verify-agent-conf tool on the manager side.

In case of setting up a directory with a wildcard in agent.conf and verifying this configuration an error message is displayed if the directory does not exist. The provided solution shows a debug message when expanding there is no directory that matches the pattern.

Logs/Alerts example

syscheck-config.c:954 at read_attr(): DEBUG: (6351): No matches found for the glob pattern: '/test/*/globpattern'

Tests

  • Compilation without warnings in every supported platform
    • Linux
  • Source installation
  • Review logs syntax and correct language
  • Retrocompatibility with older Wazuh versions
  • Working on cluster environments

@bah07 bah07 requested a review from vikman90 October 3, 2020 10:36
@bah07 bah07 self-assigned this Oct 3, 2020
@bah07 bah07 linked an issue Oct 3, 2020 that may be closed by this pull request
Comment thread src/config/syscheck-config.c Outdated
Comment thread src/config/syscheck-config.c Outdated
Borja Arroba and others added 3 commits November 20, 2020 18:09
Co-authored-by: Vikman Fdez-Castro <victor@wazuh.com>
Co-authored-by: Vikman Fdez-Castro <victor@wazuh.com>
@vikman90 vikman90 force-pushed the fim-fix-verify-conf branch from 479f88d to 26adda4 Compare November 20, 2020 17:13
@vikman90 vikman90 merged commit 76e9564 into master Nov 20, 2020
@vikman90 vikman90 deleted the fim-fix-verify-conf branch November 20, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify-agent-conf syntax problems with agent.conf

2 participants