Skip to content

SysCollector: Open other files if system information is incomplete from /etc/os-release#6674

Merged
chemamartinez merged 1 commit intomasterfrom
5731-incomplete-osinfo-osrelease
Nov 26, 2020
Merged

SysCollector: Open other files if system information is incomplete from /etc/os-release#6674
chemamartinez merged 1 commit intomasterfrom
5731-incomplete-osinfo-osrelease

Conversation

@danimegar
Copy link
Copy Markdown
Contributor

Related issue
#5731

Description

I modified the code to check other files when it is not possible to get the name, version or platform of the system from /etc/os-release

Logs/Alerts example

sqlite3 /var/ossec/queue/db/002.db "select os_name, os_version, os_major, os_minor, os_platform from sys_osinfo;"

Debian GNU/Linux|10.4|10|4|debian

Tests

  • Compilation without warnings in every supported platform
    • Linux
  • Source installation
  • Source upgrade
  • Memory tests for Linux
    • Scan-build report
    • Valgrind (memcheck and descriptor leaks check)
  • The data flow works as expected (agent-manager)

Copy link
Copy Markdown
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez chemamartinez merged commit 29768b8 into master Nov 26, 2020
@chemamartinez chemamartinez deleted the 5731-incomplete-osinfo-osrelease branch November 26, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants