Fixed oscap error with files in tmp folder#732
Merged
chemamartinez merged 10 commits into3.3from Jun 28, 2018
Merged
Conversation
vikman90
reviewed
Jun 6, 2018
| from xml.etree import ElementTree | ||
| from os import remove, close as close | ||
| from subprocess import call, CalledProcessError, STDOUT | ||
| from os import remove, close as close, pipe, fork, mkfifo |
Member
There was a problem hiding this comment.
Do we actually need pipe and fork?
Contributor
Author
There was a problem hiding this comment.
Not actually. Both are unused imports that I didn't see when I was removing dependencies.
Contributor
Author
|
Fixed unused imports. |
Now deletes the tmp folder when starting
Now deletes the tmp folder when starting
Now deletes the tmp folder when starting
chemamartinez
approved these changes
Jun 28, 2018
Contributor
|
Great job @Cerv1 !! |
Darioortegaleyva
pushed a commit
that referenced
this pull request
Feb 6, 2026
Adding SCA policies for Windows Server 2019 RTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
oscap.pydoesn't create any temporary files. Instead, it creates a FIFO file namedoscap.fifounderwodles/oscapfolder.Furthermore, agents, managers and locals now delete the content of the
tmpfolder when starting.Fixes #704