Skip to content

Fixed oscap error with files in tmp folder#732

Merged
chemamartinez merged 10 commits into3.3from
fix-oscap
Jun 28, 2018
Merged

Fixed oscap error with files in tmp folder#732
chemamartinez merged 10 commits into3.3from
fix-oscap

Conversation

@Cerv1
Copy link
Copy Markdown
Contributor

@Cerv1 Cerv1 commented Jun 6, 2018

Now oscap.py doesn't create any temporary files. Instead, it creates a FIFO file named oscap.fifo under wodles/oscap folder.

Furthermore, agents, managers and locals now delete the content of the tmp folder when starting.

Fixes #704

Comment thread wodles/oscap/oscap.py Outdated
from xml.etree import ElementTree
from os import remove, close as close
from subprocess import call, CalledProcessError, STDOUT
from os import remove, close as close, pipe, fork, mkfifo
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need pipe and fork?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually. Both are unused imports that I didn't see when I was removing dependencies.

@vikman90 vikman90 self-assigned this Jun 6, 2018
@vikman90 vikman90 added the type/bug Something isn't working label Jun 6, 2018
@Cerv1
Copy link
Copy Markdown
Contributor Author

Cerv1 commented Jun 8, 2018

Fixed unused imports.

@chemamartinez chemamartinez changed the base branch from master to 3.3 June 25, 2018 10:30
@chemamartinez chemamartinez self-requested a review June 25, 2018 10:32
@chemamartinez chemamartinez merged commit a0b31a4 into 3.3 Jun 28, 2018
@chemamartinez chemamartinez deleted the fix-oscap branch June 28, 2018 12:56
@chemamartinez
Copy link
Copy Markdown
Contributor

Great job @Cerv1 !!

Darioortegaleyva pushed a commit that referenced this pull request Feb 6, 2026
Adding SCA policies for Windows Server 2019 RTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants