Remove offset of frequency rules#827
Merged
chemamartinez merged 3 commits into3.3from Jul 3, 2018
Merged
Conversation
This was referenced Jun 21, 2018
bah07
approved these changes
Jun 27, 2018
chemamartinez
force-pushed
the
fix-rules-freq
branch
from
9964c64 to
df90a72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the issue #818.
Previously there was a +2 offset in the frequency option due to design reasons. After evaluating several options to disable the current offset, we think the least impactful option is to correct that offset when reading the rules from the XML files.
It also set the limit of the offset between 2 and 9999.
Related issue/PR: