This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Fix xtables.lock race condition between weave and kube-proxy.#3353
Merged
bboreham merged 1 commit intoweaveworks:masterfrom Jul 23, 2018
Merged
Fix xtables.lock race condition between weave and kube-proxy.#3353bboreham merged 1 commit intoweaveworks:masterfrom
bboreham merged 1 commit intoweaveworks:masterfrom
Conversation
Author
|
:-( |
Contributor
No, There are limitation w.r.t secrets to run CI against forked repo PR's. I pushed the branch to main repo. CI looks good. |
Contributor
|
Why is this different to #3134 ? |
Contributor
|
Oh, I see, it's |
bboreham
approved these changes
Jul 23, 2018
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Thanks!
BTW, just to check, I did:
$ diff weave-daemonset-k8s-1.7.yaml weave-daemonset-k8s-1.8.yaml
206a207
> type: FileOrCreate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a new prog/weave-kube/weave-daemonset-k8s-1.8.yaml with type "FileOrCreate" based on the existing 1.7 one.
I tried to take care of the release and testing too but I might be missing something. Feel free to correct me if that's the case.
Fixes #3351